patch knitr to know about OJS chunk and its comment character so opti… #7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and dot, but dot is working because already known by knitr
`knitr:::comment_chars` is available since 1.35
yihui
added a commit
to yihui/knitr
that referenced
this pull request
Dec 5, 2023
yihui
reviewed
Dec 5, 2023
cscheid
approved these changes
Dec 5, 2023
|
We might want to add an entry to the changelog as well. |
clrpackages
pushed a commit
to clearlinux-pkgs/R-knitr
that referenced
this pull request
Apr 9, 2024
Kyle F Butts (2):
Add support for `# %%` for chunk demarcation in `knitr::spin` (#2307)
make spin() recognize `#|` comments as code chunks (#2320)
Lee Mendelowitz (1):
Fix the error when kable()'s caption value is of length > 1 (#2312)
Max Schmit (1):
add ALTER as sql statment, that is not returning anything (#2330)
Yihui Xie (53):
start the next version
fix #2304: shouldn't have used `return(meta)` since `meta` is not the `citation()` but `packageDescription()`
fix rstudio/rmarkdown#2526 by reverting bebf117 since the `cairo_pdf` device has been explicitly supported in chunk_device(); now all possible `pdf()` arguments are supported, including `family`
Disallow unbalanced chunk delimiters (#2306)
close #1679: obtain the caption from the chunk option `tab.cap` for `kable()`
also try the chunk option tbl.cap when tab.cap is NULL (quarto-dev/quarto-cli#7555)
tweak R Markdown v1 vignettes
move mailing list link and use https in ref card
move css and js to jsdelivr for html_vignette
use jsdelivr for the Rhtml template
rewrite the docco classic style using JS instead of R
standardize the docco linear format
new version of funmediation is on CRAN now
support the ... argument in chunk hooks
optimize PNG images in package vignettes via optipng and pngquant if they are installed
use R Markdown v1 for the knitr-intro vignette, too
delete some files that are no longer needed in inst/examples and also ignore some files
fix #2308: don't trim trailing spaces escaped by `\`
support in-body chunk options for ojs and mermaid (quarto-dev/quarto-cli#7799)
amend 3dcfac4780accc3791855b298a556297f62dc73d to fix quarto-dev/quarto-cli#5994: add YAML options to code for dot/mermaid/ojs chunks so that the full chunk content can be returned to Quarto
add trailing slashes to URLs
use the `assert(fact, {})` syntax for all tests
revert c9473ad: map the chunk option `tbl-cap` to `tab.cap`
leave tbl.cap alone; don't convert it to tab.cap, since Quarto has its own special handling of `tbl-cap`
Create FUNDING.yml
use xfun::decimal_dot() to ensure dot as the decimal separator
fix rstudio/rmarkdown#2525: ensure the dot is used as the decimal separator even when options(OutDec) is not `.` or `LC_NUMERIC` is inappropriate
factor out code to xfun::csv_options() and xfun::divide_chunk()
get_option_comment() has been moved to xfun
roxygenize
bump xfun version
xfun 0.42 is on CRAN now
revert 87d094a6c593c31a3667821865e91b4a530018ec per request from CRAN maintainers, since _R_CHECK_VIGNETTES_SKIP_RUN_MAYBE_=true has been made the default
fix rstudio/tinytex#435: adjust PATH temporarily for pdf_crop() to be able to find the command `pdfcrop` from TinyTeX
RStudio IDE still calls parse_params(): https://github.com/rstudio/rstudio/blob/9a6196233d8eae5aa365b73eaafba04f7714190c/src/cpp/session/modules/SessionRmdNotebook.R#L666
a follow-up on #2331: use xfun::fenced_block() from yihui/xfun@22a97ce
xfun 0.43 is on CRAN now
not sure what's wrong with pak
`knitr::imgur_upload()` is now simply a wrapper function of `xfun::upload_imgur()` (#2325)
too many ways to do the same thing... drop support for `#-` in spin()
make spin() work again with input that can't be parsed as R code
use xfun::check_old_package()
markdown no longer sets this option internally, so no need to empty it now
better detection of Rmd v2 input in knit2html(), so it no longer warns against documents that use markdown:: or litedown:: output formats
make regex a little stricter so it won't match rmarkdown::
the loo issue has been fixed (#2306)
roxygen2 requires _PACKAGE now
rename class names 'block' to 'knitr_block', and 'inline' to 'knitr_inline' since I need to export the print() methods and the names 'block' and 'inline' are too general
preserve trailing \n in source code by doubling it, because later we will remove trailing \n in fenced_block()
a temporary workaround for davidgohel/flextable#621
StructFDR has been updated on CRAN but unfortunately the maintainer didn't seem to have seen my email about #2306
I can't use knitr_block/knitr_inline as class names since it would break the lightparser package; let me just get rid of these S3 methods, which are unnecessarily advanced---just use normal functions instead (i.e., use inherits() to do the dispatch by myself)
CRAN release v1.46
knokknok (1):
fix #2318: faster processing of dependencies in dep_auto() (#2321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and its comment character so options are parsed
closes #5994
@cscheid that would be the scoped way to handle a patch that does work no matter the knitr version.
The issue is the same of all special engines so this include fix for mermaid. dot was working because already known by knitr
I believe this is safe to do that, and indeed is the right way to do it for current special engine implementation.
Notice that OJS and mermaid / dot (
handledLanguages) gets exactly the same treatment, butojsis not part ofhandledLanguages, so we get two passes. I can refactor, but leaving this way makes it clear we do have different meaning forojsandmermaid/dot(and possibly more later).