Detect # headings with AST
#11841
Merged
Detect # headings with AST
#11841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
added a commit
that referenced
this pull request
Jan 14, 2025
Follow up on #11841 Otherwise filter is not found by bundled version (but test passes because dev version works)
|
When adding a filter that should be used as-is by Quarto, we need to make sure it is available in the bundled filter files. I opened a PR to fix |
|
Ugh, that's right. Thanks for catching that. We really need a way to run some tests on our bundled versions, even if it's just to catch this kind of thing right away. |
|
I'll let you rebuild a new pre-release later today as I think you may work on some other important fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
src/core/lib/markdown-analysis/level-one-headings.tswith a helper function to detect level one headings using the markdown structure of the document instead of a regex.Closes #11835.