Code in callouts in smaller slides needs to be scaled down twice #11252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because code-.*-font-size variables are set in px and not em, and we need to scaled down using `calc()` twice so that correct font is used.
cderv
added
revealjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because code-.*-font-size variables are set in px and not em, and we need to scaled down using
calc()twice so that correct font is used.Follow up on #11237
$code-inline-font-sizeand$code-block-inlineare in pixels, and so we need to have$presentation-font-smallerapplied to it, so that it gets correctly scaled down, like other text.When callouts inside
.smallercontent, the scaling factor needs to be applied twice to get correct result.This PR fixes it.
Other style issues are in #11251