serialize and deserialize custom nodes to JSON filters #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, Pandoc's Meta doesn't like to have Attr objects in it. This makes everything harder :( |
|
TODO:
|
tarleb
reviewed
Oct 30, 2024
| end | ||
| list:insert(inner) | ||
| end | ||
| return pandoc.MetaList(list) |
There was a problem hiding this comment.
Performance note: pandoc.MetaList (almost) the same as pandoc.List, the former just does a little more type correction. The latter is faster, as it's a C function.
|
|
||
| def p_string(string): | ||
| return { | ||
| "t": "String", |
There was a problem hiding this comment.
Should this be "t": "Str"? It seems that this function isn't used.
There was a problem hiding this comment.
It's been zero days since a GitHub Copilot accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11235
Custom AST nodes are now serialized to and from JSON. This enables, for example, JSON filters to emit shortcodes, callouts, etc.
In order for JSON filters to do this well, they need to be careful about the way they consume and emit the JSON structure. This will need documentation and ideally library support.
This PR unlocks the core capability.