Skip to content

Commit

Permalink
let's remove this chrome check workaround
Browse files Browse the repository at this point in the history
we need to deal with initial issue considering new chrome update
#45
  • Loading branch information
cderv committed Aug 29, 2024
1 parent 5054b30 commit 7a8d480
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions render/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ runs:
using: 'composite'
steps:
# Chrome v128 started to create problem. Pin previous version in the meantime
- name: Install Chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: 127
# - name: Install Chrome
# uses: browser-actions/setup-chrome@v1
# with:
# chrome-version: 127
# The Check Chromium step appears necessary to avoid a crash/hang when rendering PDFs
# https://github.com/quarto-dev/quarto-actions/issues/45#issuecomment-1562599451
#
# chromium is installed in the ubuntu 21 runners in GHA, so no need to install it
- name: 'Check Chromium'
if: ${{ runner.os == 'Linux' }}
run: |
echo $(which google-chrome)
$(which google-chrome) --headless --no-sandbox --disable-gpu --renderer-process-limit=1 https://www.chromestatus.com
shell: bash
#- name: 'Check Chromium'
# if: ${{ runner.os == 'Linux' }}
# run: |
# echo $(which google-chrome)
# $(which google-chrome) --headless --no-sandbox --disable-gpu --renderer-process-limit=1 https://www.chromestatus.com
# shell: bash
- name: 'Render'
env:
QUARTO_PRINT_STACK: true
Expand Down

0 comments on commit 7a8d480

Please sign in to comment.