Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singlestore jdbc: Quarkus native support #3

Merged
merged 16 commits into from
Oct 22, 2024

Conversation

Hemantkumar-Chigadani
Copy link
Contributor

@Hemantkumar-Chigadani Hemantkumar-Chigadani commented Oct 21, 2024

@Hemantkumar-Chigadani Hemantkumar-Chigadani requested a review from a team as a code owner October 21, 2024 13:07
Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in the following files:

  • .github/workflows/*
  • .github/project.yml

.github/project.yml Outdated Show resolved Hide resolved
@Hemantkumar-Chigadani
Copy link
Contributor Author

Please revert the changes in the following files:

  • .github/workflows/*
  • .github/project.yml

@gastaldi Sure, I can but these files are generated (default) by extension command expect .github/project.yml which I had updated.

@gastaldi
Copy link
Member

Yes, those files were updated recently and it is still not in a released version. I made sure they were updated when pushing to the repo

@gastaldi
Copy link
Member

Also you need to accept the invitation to join the Organization, I see the invitation is still pending

@Hemantkumar-Chigadani
Copy link
Contributor Author

Also you need to accept the invitation to join the Organization, I see the invitation is still pending

Just now accepted it, sorry I did not receive an email notification on this topic so did not notice until you mention it, Cheers

@Hemantkumar-Chigadani
Copy link
Contributor Author

Please revert the changes in the following files:

  • .github/workflows/*
  • .github/project.yml

@gastaldi Sure, I can but these files are generated (default) by extension command expect .github/project.yml which I had updated.

@gastaldi This is done now, Cheers

@gastaldi
Copy link
Member

@Hemantkumar-Chigadani when you feel it's ready go ahead and merge your first PR 😉

@Hemantkumar-Chigadani Hemantkumar-Chigadani merged commit efdd503 into quarkiverse:main Oct 22, 2024
1 check passed
@melloware
Copy link

@Hemantkumar-Chigadani you should work on the README.MD next.

@Hemantkumar-Chigadani
Copy link
Contributor Author

@Hemantkumar-Chigadani you should work on the README.MD next.

@melloware Its one of my todo list, thanks for reminding me anyway, cheers

@gastaldi
Copy link
Member

@all-contributors add @Hemantkumar-Chigadani for code and maintenance

Copy link
Contributor

@gastaldi

I've put up a pull request to add @Hemantkumar-Chigadani! 🎉

@gastaldi
Copy link
Member

@all-contributors add @melloware for review

Copy link
Contributor

@gastaldi

I've put up a pull request to add @melloware! 🎉

@gastaldi
Copy link
Member

@Hemantkumar-Chigadani you should work on the README.MD next.

@melloware Its one of my todo list, thanks for reminding me anyway, cheers

@Hemantkumar-Chigadani feel free to create issues in this repository to make sure your TODO list is completed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants