Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added src ruleset generator #106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MarvinKlemp
Copy link
Contributor

@theofidry
Copy link
Contributor

is anything missing for that one @MarvinKlemp?

@theofidry
Copy link
Contributor

On second though is it enough? What happens if we have multiple source directories, e.g. legacy and src?

@MarvinKlemp
Copy link
Contributor Author

@theofidry 👍
I added a way to define multiple source paths

If you have different source paths, you can pass them seperated by a comma.

```bash
$ deprecation-detector check src/,legacy/ vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? (the ,) And is the trailing / mandatory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the trailing slash I usually add them to make clear that it is a directory

@theofidry
Copy link
Contributor

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants