-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example fuzzer for RT-N12 B1 httpd #1480
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there and thanks for the contribution; more examples help people to moderate their learning curve.
For that very reason it is imperative that the examples will be as clean as possible and at the same time heavily commented. What are you doing and why you are doing things they way you do is key for other people to learn from the example. If too many things remain mysterious or unclear people will not learn too much, or worse, it even might confuse them.
Will appreciate you taking the time to go over the requested changes and make the necessary adjustments. Also here are a few general comments:
- Try to adhere to PEP8 conventions, it really helps to keep the code clean and tidy
- Use proper annotations also for return values, not only for arguments
- Add more comments explaining what you are doing; things that are obvious to you might not be for others
- I am not sure we are allowed to attach the firmware files here. If you have a direct like to the firmware on the vendor's website, that would be great
Cheers!
I've since run a linter to address this.
Should be fixed now.
Added multiple comment sections to aid understanding.
Removed firmware file (which was the wrong one anyway) and added a link to the manufacturer's page. |
Great, thanks for making the changes. (Make sure to tag me, so I will get notified) |
@elicn Addressed the feedback you gave. Much appreciated. |
Will someone else please approve this? |
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing