aggregate to yaml and refactor yaml_writer #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yaml_reader 不一起重构吗？ |
需要一些时间 |
qicosmos
reviewed
Nov 19, 2024
iguana/yaml_writer.hpp
Outdated
| IGUANA_INLINE void render_yaml_value(Stream &ss, const T &val, | ||
| size_t min_spaces) { | ||
| std::enable_if_t<smart_ptr_v<T>, int> = 0> | ||
| IGUANA_INLINE void render_yaml_wrapper(Stream &ss, const T &val, |
iguana/yaml_writer.hpp
Outdated
| std::enable_if_t<refletable_v<T>, int>> | ||
| IGUANA_INLINE void to_yaml(T &&t, Stream &s, size_t min_spaces) { | ||
| std::enable_if_t<refletable_v<T>, int> = 0> | ||
| IGUANA_INLINE void render_yaml_struct(Stream &s, T &&t, size_t min_spaces) { |
There was a problem hiding this comment.
这里还是用render_yaml_value比较好，统一成这个名字。
struct语义是不明确的，tuple 也算是struct的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.