-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/ubuntu migration #2268
Merged
Merged
Ci/ubuntu migration #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
This pull request introduces multiple updates to the GitHub Actions workflows, Docker configurations, and associated build scripts for the Kagome and Zombienet projects. The primary objectives are to improve the build process, enable flexibility in image customization, and standardize the use of Ubuntu (24.04 LTS) for consistency.
Key Changes
GitHub Actions Workflows
.github/workflows/*.yml
) to support additional input parameters:builder_latest_tag
andzombie_tester_latest_tag
.Dockerfile Updates
minideb.Dockerfile
tokagome_runner.Dockerfile
andkagome_builder_deb.Dockerfile
tokagome_builder.Dockerfile
for clarity.BASE_IMAGE
andBASE_IMAGE_TAG
to facilitate better compatibility and version tracking.Makefile Enhancements
OS_IMAGE
,BUILDER_IMAGE_TAG
,TESTER_LATEST_TAG
) and refactored existing rules for better image tagging and pushing processes.kagome_dev_docker_build_tidy
target to align with new Docker image parameters.New Install Scripts
install_packages
scripts for bothkagome-dev
andzombienet
to manage dependencies more robustly with retry mechanisms.Environment Variables
BUILDER_LATEST_TAG
andTESTER_LATEST_TAG
are utilized in multiple workflows for consistency.Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: