Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamProtocols are passed to p2p identify #2220

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ErakhtinB
Copy link
Contributor

Referenced issues

Closes #2217

Description of the Change

Stream Protocols for p2p Identify are configured in app injector

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@@ -335,6 +335,13 @@ namespace {
std::move(kademlia_config));
}

sptr<libp2p::protocol::IdentifyConfig> get_identify_config() {
libp2p::protocol::IdentifyConfig identify_config;
identify_config.protocols = {"/ipfs/id/1.0.0", "/substrate/1.0"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Injector is the best place to list protocol ids, but ok.

@ErakhtinB ErakhtinB force-pushed the 2217-identify-config-protocols branch from 0b33ca0 to 6e5ea41 Compare October 23, 2024 03:11
@ErakhtinB ErakhtinB enabled auto-merge (squash) October 23, 2024 03:58
@ErakhtinB ErakhtinB force-pushed the 2217-identify-config-protocols branch from 6e5ea41 to c1093e1 Compare October 23, 2024 03:59
@ErakhtinB ErakhtinB merged commit 100f8b3 into master Oct 23, 2024
16 of 21 checks passed
@ErakhtinB ErakhtinB deleted the 2217-identify-config-protocols branch October 23, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify config protocols
3 participants