Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for command line tools 16 #2216

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fixes for command line tools 16 #2216

merged 2 commits into from
Sep 18, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Sep 18, 2024

Referenced issues

None

Description of the Change

Latest Apple's command line tools 16 are breaking KAGOME build, because of issues with unique() method from shared_ptr. Replacement with use_count() fixes the issue

Possible Drawbacks

Longer if conditions

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review September 18, 2024 10:54
@kamilsa kamilsa enabled auto-merge (squash) September 18, 2024 10:55
@kamilsa kamilsa merged commit 27dda03 into master Sep 18, 2024
20 of 22 checks passed
@kamilsa kamilsa deleted the fix/cl-tools-16 branch September 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants