Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noexcept and use updated p2p & hunter #2178

Closed
wants to merge 2 commits into from

Conversation

igor-egorov
Copy link
Contributor

@igor-egorov igor-egorov commented Aug 8, 2024

Description of the Change

Fixes frequent crashes of kusama node (access to uninitialized memory at multiaddress).
Eases debugging via removing noexcept from stack traces where exceptions may be thrown.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes]

@igor-egorov igor-egorov changed the title DRAFT Fix/kusama multihash Remove noexcept and use updated p2p & hunter Aug 13, 2024
@igor-egorov igor-egorov requested review from xDimon, kamilsa and turuslan and removed request for xDimon August 13, 2024 09:30
@igor-egorov igor-egorov marked this pull request as ready for review August 13, 2024 09:38
@igor-egorov igor-egorov enabled auto-merge (squash) August 13, 2024 09:39
@igor-egorov
Copy link
Contributor Author

closed in favor of #2192

auto-merge was automatically disabled August 26, 2024 08:34

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants