-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WasmEdge JIT #2120
Closed
Closed
WasmEdge JIT #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harrm
force-pushed
the
feature/wasmedge-jit
branch
from
June 6, 2024 14:06
89b2500
to
a2dc6ac
Compare
…eature/wasmedge-jit
turuslan
reviewed
Jun 7, 2024
kamilsa
approved these changes
Jun 7, 2024
zerg-su
force-pushed
the
feature/wasmedge-jit
branch
3 times, most recently
from
June 7, 2024 17:37
b6f5c5f
to
ec67a5c
Compare
zerg-su
force-pushed
the
feature/wasmedge-jit
branch
from
June 7, 2024 17:43
ec67a5c
to
bd76cec
Compare
zerg-su
force-pushed
the
feature/wasmedge-jit
branch
from
June 7, 2024 18:34
e9b64b0
to
2e89027
Compare
This reverts commit bd76cec.
…eature/wasmedge-jit
turuslan
approved these changes
Jun 13, 2024
…eature/wasmedge-jit
turuslan
reviewed
Jun 28, 2024
@@ -13,7 +13,7 @@ | |||
#include "scale/tie.hpp" | |||
#include "scale/tie_hash.hpp" | |||
|
|||
namespace kagome { | |||
namespace kagome::runtime { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
Suggested change
namespace kagome::runtime { | |
namespace kagome { |
turuslan
reviewed
Jun 28, 2024
@@ -126,6 +126,10 @@ namespace kagome::runtime { | |||
return PtrSize{ptr, static_cast<WasmSize>(v.size())}.combine(); | |||
} | |||
|
|||
size_t size() const { | |||
return handle_->size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May make handle_
public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
closes #2115 closes #2031
Description of the Change
Introduces a newer WasmEdge that supports JIT compilation. However, as it is currently implemented in WasmEdge, it didn't actually make any improvement over AOT compilation. In the future JIT may be worked on to become useful.
Possible Drawbacks
None expected.
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: