Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WasmEdge JIT #2120

Closed
wants to merge 59 commits into from
Closed

WasmEdge JIT #2120

wants to merge 59 commits into from

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Jun 6, 2024

Referenced issues

closes #2115 closes #2031

Description of the Change

Introduces a newer WasmEdge that supports JIT compilation. However, as it is currently implemented in WasmEdge, it didn't actually make any improvement over AOT compilation. In the future JIT may be worked on to become useful.

Possible Drawbacks

None expected.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review June 6, 2024 13:56
core/utils/benchmark_main.cpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Outdated Show resolved Hide resolved
@zerg-su zerg-su force-pushed the feature/wasmedge-jit branch 3 times, most recently from b6f5c5f to ec67a5c Compare June 7, 2024 17:37
@@ -13,7 +13,7 @@
#include "scale/tie.hpp"
#include "scale/tie_hash.hpp"

namespace kagome {
namespace kagome::runtime {
Copy link
Contributor

@turuslan turuslan Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Suggested change
namespace kagome::runtime {
namespace kagome {

@@ -126,6 +126,10 @@ namespace kagome::runtime {
return PtrSize{ptr, static_cast<WasmSize>(v.size())}.combine();
}

size_t size() const {
return handle_->size();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May make handle_ public

@turuslan turuslan mentioned this pull request Jun 28, 2024
@kamilsa kamilsa closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: experimental JIT support for WasmEdge [Enhancement]: Upgrade WasmEdge to 0.14.0
4 participants