-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to update Transmission peer port #2611
base: master
Are you sure you want to change the base?
Conversation
The script `transmission-port-update.sh` updates the _peer port_ used by the torrent client Transmission. The peer port is the port used and announced by Transmission to accept incoming connections.
I've used this script and it worked on the first try. Thank you! |
Just reporting that I've been using this for over a month and it's been working flawlessly 👌 |
- better error handling - support for comma-separated list of ports (use only first one) - style corrections - improved messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review of the PR (and the wiki PR 👍 ) Just a few minor things to do if possible 🙏 thanks!
|
||
# default values | ||
DEFAULT_URL="http://localhost:9091/transmission/rpc" | ||
WGET_OPTS="--quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit just have this as --quiet
directly without a variable, to reduce the "API surface" of the script. One can always ask if they need different wget options, and we can add it as a flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved --quiet
flag out of WGET_OPTS
but I am keeping the variable to store there, if needed, the API credentials and some extra flags they require. Is this ok?
Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
The script
transmission-port-update.sh
updates the peer port used by the torrent client Transmission using its API. The peer port is the port used and announced by Transmission to accept incoming connections. You can use this script to set a VPN forwarded port as the current listening port for Transmission.The script uses only shell scripting and can run out of the box within the current
gluetun
docker image, it only relies on the commandwget
, which is already included by default in the image.