Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Qt style names in a case insensitive way #21720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle Qt style names in a case insensitive way #21720

wants to merge 1 commit into from
+2 −3

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 30, 2024

Closes #21716.

@glassez glassez added the GUI GUI-related issues/changes label Oct 30, 2024
@glassez glassez added this to the 5.0.2 milestone Oct 30, 2024
@glassez glassez requested a review from a team October 30, 2024 16:00
@glassez glassez mentioned this pull request Oct 30, 2024
Open
xavier2k6
xavier2k6 previously approved these changes Oct 30, 2024
View reviewed changes
@xavier2k6
Copy link
Member

@stalkerok please test too.

stalkerok
stalkerok approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@stalkerok stalkerok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

sledgehammer999
sledgehammer999 previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@sledgehammer999 sledgehammer999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks straight forward.
I approve since the bug reporter confirms that it fixes the problem.

Chocobo1
Chocobo1 reviewed Nov 2, 2024
View reviewed changes
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
@glassez glassez requested a review from a team November 2, 2024 13:36
@sledgehammer999
Copy link
Member

@stalkerok can you confirm that the new patch works too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@stalkerok stalkerok stalkerok approved these changes

@sledgehammer999 sledgehammer999 sledgehammer999 left review comments

@xavier2k6 xavier2k6 xavier2k6 left review comments

Assignees
No one assigned
Labels
GUI GUI-related issues/changes
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

System style (Fusion) switches to windowsvista after changing any setting
5 participants
@glassez @xavier2k6 @sledgehammer999 @Chocobo1 @stalkerok