Display External IP Address in status bar

[Piccirello]

This change displays the last detected IPv4 and/or IPv6 address(es) in the GUI and WebUI's status bar. This does not yet handle systems with multiple addresses of the same type (e.g. multiple IPv6 addresses).

This is a continuation of #20118, which has been closed. I've reused most of the code (with minor changes) but removed the ability to directly open the Execution Log by clicking on the address label.

GUI (resolution 1280x800):

WebUI:

[stalkerok]

Past comments: #20118 (comment) ("External Address" to "IP" or "External IP"), #20118 (comment) ("Detecting" to "N/A"), #20118 (comment) (Disable the default display).
And the mentioned advanced features (for other PRs): showing the country flag next to the IP and a tooltip with all detected IPs.

[Piccirello]

I went through all of the past comments and chose not to act on these. More info below.

Past comments: #20118 (comment) ("External Address" to "IP" or "External IP"), #20118 (comment)

I don't feel super strongly about this, but "Address" seems appropriate to use here.

("Detecting" to "N/A"), #20118 (comment)

"Detecting" is more accurate than "N/A", given that a) we're waiting to resolve the IP and b) "N/A" means "not applicable" (this doesn't really apply here). I also disagree with the notion that "Detecting" takes up too much space, as seen in the GUI screenshot above on a low resolution display.

(Disable the default display).

I'm not opposed to adding an option for this, though I'd push for enabling this feature by default.

And the mentioned advanced features (for other PRs): showing the country flag next to the IP and a tooltip with all detected IPs.

Agree that these can be added later if people desire.

[glassez]

"Detecting" is more accurate than "N/A", given that
a) we're waiting to resolve the IP

IMO, it can be perceived as some kind of active action of qBittorrent, but it is not. Moreover, it will never detect the external address without having active torrents.

b) "N/A" means "not applicable" (this doesn't really apply here).

This statement is speculative. "N/A" can also mean other things, e.g. "not available" which is used in this case.

[glassez]

I went through all of the past comments and chose not to act on these.

If you didn't figure it out, it was those comments that were the problem.

[Piccirello]

I went through all of the past comments and chose not to act on these.

If you didn't figure it out, it was those comments that were the problem.

There were many comments, almost all of which I addressed. These remaining comments seem minor. And if I'm being totally honest, I think it was your tone and manor of interacting with the author that lead to them abandoning the PR. You can come across as very terse.

This statement is speculative. "N/A" can also mean other things, e.g. "not available" which is used in this case.

That's not what it means though.

[stalkerok]

I don't feel super strongly about this, but "Address" seems appropriate to use here.

In the log there are strings Detected external IP. IP: “...”, the same here, but without Detected external IP..

IMO, it can be perceived as some kind of active action of qBittorrent, but it is not.

This statement is speculative. "N/A" can also mean other things, e.g. "not available" which is used in this case.

👍
The external address may never be detected (when using a proxy, for example).

Moreover, it will never detect the external address without having active torrents.

A working DHT is sufficient for detection.

[glassez]

This statement is speculative. "N/A" can also mean other things, e.g. "not available" which is used in this case.

That's not what it means though.

https://wikipedia.org/wiki/Not_available

[glassez]

Moreover, it will never detect the external address without having active torrents.

A working DHT is sufficient for detection.

I'm not sure that DHT is queried for anything when there are no running torrents. However, it doesn't matter. I just wanted to emphasize that "external address" is information that is obtained as a side effect, and not as a result of active actions.

[stalkerok]

I'm not sure that DHT is queried for anything when there are no running torrents.

#21296 (comment) In the screenshots you can see that if DHT is working, the external address will be detected (without active torrents).

[Piccirello]

This statement is speculative. "N/A" can also mean other things, e.g. "not available" which is used in this case.

That's not what it means though.

https://wikipedia.org/wiki/Not_available

That's not the usage I think of when I hear "N/A", but that's just my bias.

I'll switch from "External Address" to "External IP" and from "Detecting" to "N/A".

https://github.com/qbittorrent/qBittorrent/compare/24aa88a28439bed5682d6d0e11cd65db5ee06cc3..45ceb1465199d04d2da3acd231fbbe8763480304

[stalkerok]

I'm not opposed to adding an option for this, though I'd push for enabling this feature by default.

Any other opinions? Even if you leave the default display, there should be a checkbox in the options to disable the display.

[sledgehammer999]

I am questing the usefulness of this. Why isn't the log entry sufficient?
Also, I think it will contribute to UI clutter.

[luzpaz]

IMHO, if it's optional (via preferences) then I see no harm in it. There are many requests for this functionality IIRC.

[sledgehammer999]

Another question: Is this mostly useful to WebUI users? Or do GUI users stand to benefit from it too?

[HanabishiRecca]

Why isn't the log entry sufficient?

E.g. my ISP sometimes drops my static IP, effectively blocking the transfers. And it's not always obvious at the first glance if there is simply no activity or something is broken, it requires reading the log.

Is this mostly useful to WebUI users? Or do GUI users stand to benefit from it too?

I don't see how UI choice matters here. It serves the same purpose for both.

[sledgehammer999]

E.g. my ISP sometimes drops my static IP, effectively blocking the transfers.

Wait. I think I am missing something. If the ISP drops the static IP don't you get assigned another IP? Then why doesn't qbt/libtorrent continue transfers?

In any case, if I am the only member who thinks that it clutter the UI, then disregard me. I will not insist.

[Piccirello]

It seems folks are currently in agreement that there should be a way to disable this. Is that right? Anything else missing?

[HanabishiRecca]

Yes. Even without clutter take, hiding it should be possible for privacy reasons.

Streamer mode in qBittorrent when?

[stalkerok]

Works fine.

[Piccirello]

Are there any other blockers on this PR?

[stalkerok]

@Chocobo1 Do you have any other comments? I would test again.

[Danny3]

This could be a privacy & security nightmare if it's on by default.
Especially with new Windows like Recall which always captures the screen and might even use OCR to transform everything into text.
But of course normal spyware can also do that.
Or just the users capturing the screen for somehting and forgetting about it.
If they are in a live stream, than that's even worse.

While cool to have, I think it should never be enabled by default!

[luzpaz]

Especially with new Windows like Recall which always captures the screen and might even use OCR to transform everything into text.

TBH, that is already a preexisting privacy nightmare.

[Danny3]

Especially with new Windows like Recall which always captures the screen and might even use OCR to transform everything into text.

TBH, that is already a preexisting privacy nightmare.

Yes, but having your IP address shown anywhere in the graphical interface will make the nightmare even worse.
I bet even if you have a dynamic IP would not matter as I bet it will record it every time is changed.
So I bet they could go back into Recall's history to find out what IP you had on day X.

AFAIK at the moment no other program shows the current IP address in its graphical interface.

Now that I'm thinking more about it, not only the Windows user that has Recall installed will have its privacy tarnished, but also the ones that appear in the Peers list.

So in my opinion, it would be best for the privacy of everyone if the IP addresses are not displayed by default both in the status bar and in the Peers tab for people that have Recall installed.

[HanabishiRecca]

That's kinda long and complicated way to ask for it to be disabled by default.

I also think it should not be enabled by default. Not even only for privacy reasons, but simply because most users won't need it.

[Piccirello]

All comments addressed.

Folks seem to feel strongly that this should be disabled by default. No one has expressed a strong opinion that this should be enabled by default, so I've made that change too.

[stalkerok]

At startup the IP is displayed, but the checkbox is disabled. If you go to the options and change any other setting and apply it, the IP disappears. At the next startup everything repeats.

[HanabishiRecca]

Yeah, we forgot about the initial widget state.

[Piccirello]

At startup the IP is displayed, but the checkbox is disabled. If you go to the options and change any other setting and apply it, the IP disappears. At the next startup everything repeats.

Good catch. Just put up a fix.

[stalkerok]

Tested 👍