Fix Fivemerr bug and Tweets on Linux hosts bug #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o improved a few of the if conditions
|
I think both the Webhook and the API token were in the server.lua because of security reason. Since the config.lua is shared, then it can be access by the client, and with some not authorised FiveM modifications I think they can get it. On the other hand, being in the s we server it cannot be access by anyone. |
|
Yeah those variables are sensitive and should be server-side only. |
mbiddle
changed the title
|
Updated. Not much to this change anymore but I still think it fixes a tiny bug. |
|
Pushed an additional change to switch to using the native shared Round function and to remove the local function. |
…ime works for me in the on linux so I think this is a proper fix.
mbiddle
changed the title
|
Pushed an additional change that fixes a bug with the date/time on Linux hosts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the config.lua should be the only place config parameters are being set. I moved the WebHook and FivemerrApiToken definitions to config.lua and also improved a few of the if conditions.
Checklist