Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(garages): Blank phone screen | v1 garages #383

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(garages): Blank phone screen | v1 garages #383

merged 2 commits into from
Nov 6, 2023

Conversation

Sharkiiie
Copy link
Contributor

Description

Fixes blank phone screen and removed old v1 garage data handling.

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

The garages config was previously used to get the garage label. The label is now passed through the player vehicles CB.
The garages CB formats this data its self.
@SirDoodlesNY
Copy link

SirDoodlesNY commented Nov 5, 2023

I did a fresh install of QB-Core onto my server and the phone was blank except for the qbcore image. I tried the updated qb-phone as of today and I am still getting the blank screen on the phone. After the update I did a full restart of the server too.

blank_phone

@Sharkiiie
Copy link
Contributor Author

@SirDoodlesNY Did you add the changes from this PR?
This PR has not been merged yet. There is another in qb-garages to fix another bug with the vehicles app.

@SirDoodlesNY
Copy link

SirDoodlesNY commented Nov 5, 2023

@Sharkiiie It is working now.

This is my first time using GitHub for working with issues, I didn't know to do the other PR's to fix it. Thanks :)

Copy link
Contributor

@singh-manavv singh-manavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixed the changes caused in the previous PR.

@GhzGarage GhzGarage merged commit b0b4d2a into qbcore-framework:main Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants