-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Money as Item #1152
base: main
Are you sure you want to change the base?
Feat: Money as Item #1152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the way you approached having this as a config option, defaulting to false.
The way the player.lua was implemented, Would be much better broken out to a function to prevent the repeated code.
…ogic into a single function
Done!! Thanks for the comment |
Curious, how does this handle negative amounting? |
Well I think that if a server wants its money as item, they would not let that account to be in negative terms. But in case it does, it is all handled by the inventory script. It is how this resource handle it what will determine the outcome. I don't know if I have explained myself correctly. But I don't think modern inventories allow negative quantities of items. |
I have test this in my server and I've solved some errors, now works fine |
I tested if the infinite error is solved and the error that you couldn't put money in trunks and other inventories and they are solved everything works fine for me too. |
Description
I don't know why QBCore has never include this feature widely used by RP servers. Some inventories include this feature, but I don't think it is a job for inventory, I believe it is for the core framework of the server. The only thing to take into account is that I'm using a function exported from the qb-inventory, so other inventories should adapt to this change and provide compativility.
Open to suggestions!!
Did not see this suggestion previously, but it seems this aproach this issue/suggestion: #930
Checklist