Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Authentic Nepali food items (Momo) #1150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nepal4972
Copy link

Description

This PR adds a new item, Momo, an authentic Nepali food item, to the items.lua file in QBCore. The item has been configured with a unique name, label, weight, image, and useable properties.

Checklist

  • [x ] I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • [x ] My code fits the style guidelines.
  • [x ] My PR fits the contribution guidelines.

Copy link
Contributor

@RojinxChhetri RojinxChhetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort in submitting this PR. However, I believe this change is unnecessary. If you need the momo item specifically for your server, it can be added locally without merging it into the shared codebase, as it may not be relevant or useful for others.

If you want to contribute items, I would suggest creating something more universally useful, along with its functionality, that would benefit everyone rather than being specific to a particular region.

Based on my review, I recommend closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants