Skip to content

Commit

Permalink
Include .json extension in MANIFEST.in.
Browse files Browse the repository at this point in the history 
Not doing so causes nothing in the data directory to be included in the
distribution.
  • Loading branch information
@skytreader
skytreader committed May 28, 2018
1 parent 16d1a61 commit 3b7be05
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion MANIFEST.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ include CHANGELOG.rst
include requirements.txt
include setup.cfg

recursive-include data *
recursive-include data *.json
recursive-include docs *

1 comment on commit 3b7be05

@pawamoy
Copy link

@pawamoy pawamoy commented on 3b7be05 Nov 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work though? It seems the packages published on pypi.org still don't have the JSON files included.
Maybe it should be recursive-include data data/*.json? Or recursive-include data **/*.json?

If you don't worry about potential additional files in the data directory in the future, I think you could use graft data instead: https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands

EDIT: my bad, the files are included, the issue just comes from #2309

Please sign in to comment.