Skip to content

Test also computed values

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 11, 2024 in 39s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.51 (9.88 -> 9.37)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_mersi_l1b.py: _get_1km_data
  • Complex Method test_mersi_l1b.py: MERSI12llL1BTester.test_all_resolutions

Annotations

Check warning on line 529 in satpy/tests/reader_tests/test_mersi_l1b.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MERSI12llL1BTester.test_all_resolutions has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 213 in satpy/tests/reader_tests/test_mersi_l1b.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

_get_1km_data has 71 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.