Modis l2 available datasets #913
+147
−40
Open
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Dec 12, 2023 in 51s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method file_handlers.py: BaseFileHandler.available_datasets
- Bumpy Road Ahead modis_l2.py: ModisL2HDFFileHandler.available_datasets
Annotations
Check warning on line 185 in satpy/readers/modis_l2.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
ModisL2HDFFileHandler.available_datasets has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 285 in satpy/readers/file_handlers.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
BaseFileHandler.available_datasets increases from 70 to 73 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading