Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rayleigh correction on VIIRS false_color for I02 band #2970

Merged

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Nov 7, 2024

Remove attempt to Rayleigh correct the VIIRS I02 band for the false-color RGB. The band is beyond 0.8 micron and there is effectively no rayleigh scattering in this band. Pyspectral cannot correct this anyhow.

We get warning messages in our production, like this:
WARNING pyspectral.rayleigh] Effective wavelength for band I02 outside nominal 400-800 nm range!

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@adybbroe adybbroe self-assigned this Nov 7, 2024
@adybbroe adybbroe removed their assignment Nov 7, 2024
@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 7, 2024

Here is the spectral response function of I2 for reference:

rsr_band_I2

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (9d6a879) to head (573de5e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2970   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         377      377           
  Lines       55134    55134           
=======================================
  Hits        52984    52984           
  Misses       2150     2150           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11720609195

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.206%

Totals Coverage Status
Change from base Build 11720571998: 0.0%
Covered Lines: 53228
Relevant Lines: 55327

💛 - Coveralls

@adybbroe
Copy link
Contributor Author

adybbroe commented Nov 7, 2024

FYI: I checked for possible other attempts to correct outside 400-800 micron, and couldn't find it in viirs.yaml at least. Nothing more on M07 or I2.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit b00ceac into pytroll:main Nov 7, 2024
18 checks passed
@djhoese djhoese changed the title Remove attempt to Rayleigh correct the VIIRS I02 band Remove rayleigh correction on VIIRS false_color for I02 band Nov 7, 2024
@djhoese
Copy link
Member

djhoese commented Nov 7, 2024

I've updated the title to reflect that this is for the false color RGB specifically.

@@ -232,7 +232,7 @@ composites:
modifiers: [sunz_corrected, rayleigh_corrected]
optional_prerequisites:
- name: I02
modifiers: [sunz_corrected_iband, rayleigh_corrected_iband]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rayleigh be removed from the M05 band too? I suppose that is still in the "correctable" range?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants