-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rayleigh correction on VIIRS false_color for I02 band #2970
Remove rayleigh correction on VIIRS false_color for I02 band #2970
Conversation
…icron Signed-off-by: Adam.Dybbroe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2970 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 377 377
Lines 55134 55134
=======================================
Hits 52984 52984
Misses 2150 2150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11720609195Details
💛 - Coveralls |
FYI: I checked for possible other attempts to correct outside 400-800 micron, and couldn't find it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've updated the title to reflect that this is for the false color RGB specifically. |
@@ -232,7 +232,7 @@ composites: | |||
modifiers: [sunz_corrected, rayleigh_corrected] | |||
optional_prerequisites: | |||
- name: I02 | |||
modifiers: [sunz_corrected_iband, rayleigh_corrected_iband] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rayleigh be removed from the M05 band too? I suppose that is still in the "correctable" range?
Remove attempt to Rayleigh correct the VIIRS I02 band for the false-color RGB. The band is beyond 0.8 micron and there is effectively no rayleigh scattering in this band. Pyspectral cannot correct this anyhow.
We get warning messages in our production, like this:
WARNING pyspectral.rayleigh] Effective wavelength for band I02 outside nominal 400-800 nm range!
AUTHORS.md
if not there already