-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cira stretch upcasting the data #2956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 377 377
Lines 55074 55089 +15
=======================================
+ Hits 52924 52939 +15
Misses 2150 2150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! One request inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one with splitting up the test function!
Pull Request Test Coverage Report for Build 11515862200Details
💛 - Coveralls |
The
cira_stretch
does a upcast on the data fromfloat32
tofloat64
. This PR changes the_cira_stretch
so that the small values are clipped infloat64
base and passed on tonp.log10()
as such, which returns the data as thedtype
of the input data.The
match_dtype
kwarg was added torun_and_check_enhancement()
helper function in enhancement tests. This could be added to other where applicable. I first added thedtype
tests to all calls, but there were someint64
input data and didn't want to figure out which tests expect thedtype
to stay the same and which enhancements expect it to change.