Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rayleigh correction to use the same datatype as the input data #2954

Merged
merged 8 commits into from
Oct 25, 2024

Remove unnecessary dtype parametrization

3f1076a
Select commit
Loading
Failed to load commit list.
Merged

Fix Rayleigh correction to use the same datatype as the input data #2954

Remove unnecessary dtype parametrization
3f1076a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 25, 2024 in 1m 36s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.01 (7.54 -> 7.55)

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

Annotations

Check notice on line 1 in satpy/tests/test_composites.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1484 to 1494, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 328 in satpy/tests/test_composites.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments

TestRatioSharpenedCompositors.test_ratio_sharpening increases from 5 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check notice on line 352 in satpy/tests/test_composites.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Excess Number of Function Arguments

TestRatioSharpenedCompositors.test_self_sharpened_basic has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check notice on line 567 in satpy/tests/test_modifiers.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments

TestPSPRayleighReflectance.test_rayleigh_corrector increases from 9 to 10 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.