Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image comparison behave tests #2912

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

edit path

a326b11
Select commit
Loading
Failed to load commit list.
Open

add image comparison behave tests #2912

edit path
a326b11
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Sep 27, 2024 in 1m 9s

CodeScene PR Check

Code Health Quality Gates: OK

Code Health of new files: 9.93

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments modify_image.py: add_text_to_image

Annotations

Check warning on line 22 in satpy/tests/behave/modify_image.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

add_text_to_image has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.