Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments on a multi-file reader #2697

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers future ideas Wishes and ideas for the future labels Dec 18, 2023
@mraspaud mraspaud self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e20ea41) 95.39% compared to head (4b6398b) 95.39%.
Report is 37 commits behind head on main.

Files Patch % Lines
satpy/readers/yaml_reader.py 91.42% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2697   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         371      372    +1     
  Lines       52704    52768   +64     
=======================================
+ Hits        50277    50340   +63     
- Misses       2427     2428    +1     
Flag Coverage Δ
behaviourtests 4.17% <18.84%> (+0.01%) ⬆️
unittests 96.01% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

An error occurred during the process.

1 similar comment
@rymdulf
Copy link

rymdulf commented Nov 18, 2024

An error occurred during the process.

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_feature-multifile-handler:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/pytroll/satpy.git --branch feature-multifile-handler /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 126.

Copy link
Collaborator

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

The testing process was executed successfully. See the test results for this pull request here!

Copy link

@catdieval catdieval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 18, 2024

The testing process was executed successfully. See the test results for this pull request here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements future ideas Wishes and ideas for the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an alternative to the YamlReader/FileHandler scheme for better synergy in multi-file datasets
4 participants