Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default filename for cf writer to be compatible with satpy_cf_nc reader #1637

Merged
merged 11 commits into from
Jun 24, 2024
Merged

Change default filename for cf writer to be compatible with satpy_cf_nc reader #1637

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5f8d072
refactor: default filename pattern
BENR0 Apr 12, 2021
6666c4b
refactor: add instrument to root attrs
BENR0 Apr 12, 2021
1898acc
Merge branch 'main' into feat_default_filename_cf_writer
Aug 16, 2022
f123e23
refactor: add generic filename to reader yaml
Aug 16, 2022
fd2669e
refactor: remove adding instrument to root attrs
BENR0 Aug 22, 2022
612b738
fix: remove unnecessary code introduced by merge
BENR0 Aug 22, 2022
c9476f5
fix: add reader name to test
BENR0 Aug 22, 2022
e82d4fd
Merge branch 'main' into feat_default_filename_cf_writer
BENR0 Oct 13, 2022
8d076ac
Merge branch 'main' into feat_default_filename_cf_writer
BENR0 May 25, 2023
a3af13d
refactor: change filename to stem
BENR0 May 25, 2023
82b858e
refactor: remove stem.nc from yaml config again
BENR0 Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion satpy/etc/writers/cf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ writer:
name: cf
description: Generic netCDF4/CF Writer
writer: !!python/name:satpy.writers.cf_writer.CFWriter
filename: '{name}_{start_time:%Y%m%d_%H%M%S}.nc'
filename: '{platform_name}-{sensor}-{start_time:%Y%m%d%H%M%S}-{end_time:%Y%m%d%H%M%S}.nc'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it was mentioned in the comments, but does anyone know/remember where this - separate filename came from? As you mentioned it seems to have existed in the reader first, but it isn't clear to me why/where from.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my question here still stands, but not sure we're going to get anyone who has a real answer.

compress: DEFLATE
zlevel: 6
Loading