feature: expect_override decorator to mark model methods safe for overriding #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, transition will not decorate models with trigger and convenience functions if they are already defined on the model. The check is done in
Machine._checked_assignment
. Users had to override_checked_assignment
if they wanted to define model methods (e.g. for type checking) and have them overridden by transitions during runtime. This approach is an all or nothing solution. Withexpect_override
, transitions now features an approach where developers can explicitly mark model methods that are intended to be overriden.This is a step in the effort to improve the typing support of transitions.
Some related issues: