Disable integration test between optimizer-in-backward and pp #793
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est with dp, tp, hsdp, cp
facebook-github-bot
added
the
CLA Signed
mori360
commented
Jan 16, 2025
| @@ -81,30 +81,37 @@ def __init__( | |||
| ) -> None: | |||
| self.optimizers = [] | |||
| self.model_parts = model_parts | |||
| optim_dict = {} | |||
There was a problem hiding this comment.
collect all optims in optim_dict, avoid bugs with only valid hooks at the last self.model_parts if len(self.model_parts)>1 (for future support of multi schedule pp)
There was a problem hiding this comment.
The fix for optim dict lgtm
wconstab
approved these changes
Jan 16, 2025
| @@ -127,6 +134,10 @@ def build_optimizers( | |||
| step() and zero_grad() method for all the child optimizers. | |||
| """ | |||
| optim_in_bwd = job_config.optimizer.early_step_in_backward | |||
| if optim_in_bwd and job_config.experimental.pipeline_parallel_degree > 1: | |||
| raise NotImplementedError( | |||
| "Optimizers in backward is not supported with pipeline parallelism." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizer-in-backward would free gradients memory during backward, causing integration test failure with pp at gradient scale
Disable test with pp first, would enable later with support to multi schedule pp
Add test with dp, tp, cp, hsdp