Add validation that batch size is divisible by number of microbatches #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Jan 9, 2025
ghstack-source-id: b111e687be74fe7d371b21536df662d622d9e6e3 Pull Request resolved: #784
facebook-github-bot
added
the
CLA Signed
c-p-i-o
approved these changes
Jan 9, 2025
tianyu-l
approved these changes
Jan 9, 2025
H-Huang
added a commit
that referenced
this pull request
Jan 10, 2025
ghstack-source-id: b111e687be74fe7d371b21536df662d622d9e6e3 Pull Request resolved: #784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For PP, the batch size should be divisible by number of microbatches so we should fail early if this is not the case