Init weights only if not loading a checkpoint #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the weights is wasteful if a checkpoint will be loaded.
This assumes that checkpoints are complete (loadable in
strict=True
mode). Let me know if that's too strong of an assumption generally.It might also be problematic with non_persisent=True buffers, if they were supported (#316). That is if you expect to initialize them in
init_weights
. Although one could argue for a separateinit_buffers()
method