Enable FSDP2 cpu offloading #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Oct 24, 2024
train.py
Outdated
| @@ -169,13 +166,15 @@ def loss_fn(pred, labels): | |||
| else "cuda" | |||
| ) | |||
| model.to_empty(device=init_device) | |||
| model.init_weights() | |||
| if job_config.training.enable_cpu_offload: | |||
| with torch.device("cuda"): | |||
There was a problem hiding this comment.
I somehow think the model.init_weights(buffer_device="cuda") change sounds better. It is straightforward on what we want to achieve, while making minimum change to code.
mori360
commented
Oct 24, 2024
tianyu-l
reviewed
Oct 25, 2024
train.py
Outdated
| init_device = ( | ||
| "cpu" | ||
| if job_config.checkpoint.create_seed_checkpoint | ||
| or job_config.training.enable_cpu_offload |
There was a problem hiding this comment.
Don't we need to do the same for the PP case (several lines above)? Or are we assuming if PP is used, CPU offloading is not an option?
There was a problem hiding this comment.
I test it with pp.
Based on llama2_7b.toml, cpu_offload also works but has a much obvious latency in training.
mori360
commented
Oct 28, 2024
| "Enable CPU Offload with PP", | ||
| "enable_cpu_offload+PP", | ||
| ngpu=4, | ||
| ), |
There was a problem hiding this comment.
test with pp, could remove pp later if not necessary in the CI test
tianyu-l
reviewed
Oct 28, 2024
mori360
added a commit
to mori360/torchtitan
that referenced
this pull request
Nov 26, 2024
resolve pytorch#620 Add config: `--training.enable_cpu_offload` Command: `CONFIG_FILE="./train_configs/llama3_8b.toml" ./run_llama_train.sh` For non-pp case: <img width="611" alt="Screenshot 2024-10-23 at 1 45 56 PM" src="https://github.com/user-attachments/assets/8692f8a6-c0f3-460e-8eb6-7f7195bed370"> For pp case: <img width="587" alt="cpu offload+pp" src="https://github.com/user-attachments/assets/73e40861-47e2-4845-a41c-4bfea2860109">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #620
Add config:
--training.enable_cpu_offloadCommand:
CONFIG_FILE="./train_configs/llama3_8b.toml" ./run_llama_train.shFor non-pp case:
For pp case:
