separate outputs #334
Closed
separate outputs #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
Closed
facebook-github-bot
added
the
CLA Signed
wconstab
commented
May 15, 2024
| run_test(test_flavor, full_path) | ||
|
|
||
| # Deleting checkpoint folder from test |
There was a problem hiding this comment.
Not sure why we did this in the first place. The ckpts were already in separate dirs so they wouldn't interfere. And now that I am preserving output artifacts, it makes sense to keep them.
wconstab
commented
May 15, 2024
| @@ -118,15 +137,5 @@ def run_test(test_flavor: OverrideDefinitions, full_path: str): | |||
| config = tomllib.load(f) | |||
| is_integration_test = config["job"].get("use_for_integration_test", False) | |||
| if is_integration_test: | |||
| test_flavors = [OverrideDefinitions()] + integration_tests_flavors[ | |||
There was a problem hiding this comment.
OverrideDefinitions() from here got move to the top as 'Default' entry, but specified its own output dir.
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: e512c34fa1800d00f36947fbcaed96b026fb98cd Pull Request resolved: #334
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: 1072f96b4318e2321a212c3d4f45a8155511a795 Pull Request resolved: #334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):