[bots] PR gets ciflow/trunk on import #5836
Open
+144
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
izaitsevfb
reviewed
Oct 28, 2024
| return; | ||
| } | ||
|
|
||
| const asPR = await context.octokit.pulls.get({ |
There was a problem hiding this comment.
we probably need to check that issue comment is actually a pr?
|
you can reuse additional tests from #5838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5795
There was a case where the pr body didn't get edited when the PR was imported, so we should also handle this case, which I identify by seeing if the comment got added
I think the rule is :
Random but I think ghimport uses 2 spaces after the period, but the facebook-github-bot uses 1