-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Algorithm] Update SAC Example #1524
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
9045977
fix
BY571 7d42ba5
update optimizer
BY571 738c6df
fix
BY571 e3e4ced
add init alpha option
BY571 2897340
logalpha fix
BY571 f83c6e6
naming fixes
BY571 e58b9b0
fix
BY571 1956d80
update logging small fixes
BY571 8a60301
add wd
BY571 e56b46b
add eps
BY571 220861a
no eps
BY571 0974772
undetach q at actorloss
BY571 ac54930
tests
BY571 1cfc821
update test
BY571 500bd5d
update test
BY571 4b23446
update config, test add set_gym_backend
BY571 567cd2b
update header
BY571 e5a96af
Merge remote-tracking branch 'origin/main' into sac_benchmark
vmoens ede6064
fix max episode steps
BY571 b2a04e6
update objective
BY571 1bf7382
update objective
BY571 a04437d
Merge branch 'main' into sac_benchmark
BY571 01d6e56
sep critic opti
BY571 522d061
fixes
BY571 67e47b6
fix
BY571 5af2d9a
logexp test
BY571 7546aad
frameskip weight decay
BY571 06c2e68
fix frameskip, scratchdir buffer
BY571 25cf664
update config
BY571 9a7b0b4
undo stepcount
BY571 0c8a1c4
merge main
BY571 0272f03
Merge branch 'main' into sac_benchmark
vmoens f4f65a5
fix config
BY571 d0a6fab
merge main
BY571 b0a3799
amend
vmoens b758607
amend
vmoens f0482c7
amend
vmoens fbbc287
amend
vmoens b5673fb
empty
vmoens 727776e
Merge branch 'main' into sac_benchmark
vmoens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we group all the logging in a single function, to avoid overloading the training loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, if you can have a look at the DDPG PR I tried to compress the logging but I'm open to other ideas to do it.