Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algorithm] Update DQN example #1512

Merged
merged 66 commits into from
Dec 7, 2023
Merged

Conversation

albertbou92
Copy link
Contributor

Description

Reproduce known DQN benchmarks.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2023
@vmoens vmoens added the new algo New algorithm request or PR label Sep 15, 2023
@vmoens vmoens changed the title [WIP] Update DQN example [Algorithm] Update DQN example Sep 15, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

examples/dqn/dqn_atari.py Show resolved Hide resolved
examples/dqn/dqn_carpole.py Outdated Show resolved Hide resolved
@@ -0,0 +1,171 @@
"""
DQN Benchmarks: CartPole-v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks in the repo is intended for runtime benchmark.
I would call this evaluation. At the end of the day, I think that what we will want is the following directory tree:

torchrl/
    ├── benchmarks/
    │   ├── component_x/
    │   │   ├── benchmark_workflow_1/
    │   │   ├── benchmark_workflow_2/
    │   │   └── ...
    │   ├── algorithm_y/
    │   │   ├── benchmark_workflow_1/
    │   │   ├── benchmark_workflow_2/
    │   │   └── ...
    │   └── ...
    ├── evaluation/
    │   ├── component_x/
    │   │   ├── evaluation_metrics_1/
    │   │   ├── evaluation_metrics_2/
    │   │   └── ...
    │   ├── algorithm_y/
    │   │   ├── evaluation_metrics_1/
    │   │   ├── evaluation_metrics_2/
    │   │   └── ...
    │   └── ...
    └── ...

cc @matteobettini @BY571

examples/dqn/dqn_carpole.py Outdated Show resolved Hide resolved
examples/dqn/dqn_atari.py Outdated Show resolved Hide resolved
examples/dqn/dqn_atari.py Outdated Show resolved Hide resolved
examples/dqn/dqn_atari.py Outdated Show resolved Hide resolved
examples/dqn/dqn_cartpole.py Outdated Show resolved Hide resolved
examples/dqn/dqn_cartpole.py Outdated Show resolved Hide resolved
examples/dqn/dqn_cartpole.py Outdated Show resolved Hide resolved
Copy link

pytorch-bot bot commented Nov 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1512

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (9 Unrelated Failures)

As of commit 97e7aa5 with merge base 25bd8a5 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vmoens
Copy link
Contributor

vmoens commented Dec 7, 2023

@albertbou92 the example CI is failing bc we did not update the runs there

@vmoens vmoens merged commit 4a6cc52 into pytorch:main Dec 7, 2023
52 of 61 checks passed
@albertbou92 albertbou92 deleted the update_dqn_example branch January 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants