Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unflatten traced module #954

Merged
merged 28 commits into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
931b2da
Initial add of unflattener
kwen2501 Feb 23, 2024
7656631
Unit tests passed
kwen2501 Feb 28, 2024
ea07600
Lint
kwen2501 Feb 28, 2024
b314803
Skip format check for unflatten.py
kwen2501 Feb 28, 2024
a76d23a
Move ATen registration from pytorch to pippy
kwen2501 Feb 28, 2024
f204470
Privatize functions
kwen2501 Feb 28, 2024
4103fe8
De-multi-use test_pipe_bwd.py
kwen2501 Feb 28, 2024
9d9f7c3
Re-enable auto-split
kwen2501 Feb 28, 2024
250c4a6
Add unflatten test
kwen2501 Mar 4, 2024
455bc67
Add transformer test
kwen2501 Mar 4, 2024
4de7fc2
Add test to CI
kwen2501 Mar 4, 2024
83b80d3
Add pipe.get_stage_module
kwen2501 Mar 4, 2024
27d9145
update requirement to 2.3
kwen2501 Mar 4, 2024
831c468
Merge branch 'main' into unflatten
kwen2501 Mar 28, 2024
d7bbfb1
Remove shared param from skip conn test
kwen2501 Mar 28, 2024
1e580e4
Merge branch 'main' into unflatten
kwen2501 Mar 28, 2024
03403c5
Include pre-release version in CI
kwen2501 Mar 28, 2024
4783b70
Fix CI yaml
kwen2501 Mar 28, 2024
4fd949d
Remove shape prop; use shape info from export
kwen2501 Mar 28, 2024
870704b
Another try to fix CI
kwen2501 Mar 28, 2024
6d79051
Revert url change
kwen2501 Mar 28, 2024
8ec6cc6
Remove shared param from test_optim
kwen2501 Mar 28, 2024
01499ad
Add layout
kwen2501 Mar 28, 2024
f62d53e
Extend op device modification for unflatten case
kwen2501 Apr 1, 2024
925a646
Use register_module instead of setattr
kwen2501 Apr 1, 2024
eff4666
Merge branch 'main' into unflatten
kwen2501 Apr 1, 2024
c884859
Disable BERT and T5 CI
kwen2501 Apr 1, 2024
567c365
Update backward test url
kwen2501 Apr 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ exclude =
./torch/include,
./torch/lib,
./venv,
./pippy/fx,
./pippy/unflatten.py,
*.pyi
6 changes: 6 additions & 0 deletions .github/workflows/pippy_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,16 @@ jobs:
if [ -f requirements.txt ]; then pip install -r requirements.txt --find-links https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html; fi
- name: Install pippy
run: "python setup.py install"
# IR tests
- name: Test forward pipe generation
run: python test/test_pipe.py
- name: Test backward pipe generation
run: python test/test_pipe_bwd.py
- name: Test unflatten
run: python test/test_unflatten.py
- name: Test Transformer
run: python test/test_transformer.py
# Runtime tests
- name: Run forward-only integration test
run: torchrun --nproc-per-node 4 test/test_fwd.py
- name: Run forward-loss-backward integration test
Expand Down
2 changes: 1 addition & 1 deletion check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ RETVAL=0

if (( SKIP_FORMAT == 0 )); then
echo; echo "Running format check ..."
ufmt diff pippy/*.py pippy/hf/*.py test/*.py
ufmt diff pippy/*.py test/*.py
(( RETVAL |= $? ))
fi

Expand Down
2 changes: 1 addition & 1 deletion format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
DEFAULT_TARGETS=()
for f in $(git ls-files | grep '\.py$'); do
case "$f" in
'pippy/fx/'*)
'pippy/unflatten.py')
# ignore
;;

Expand Down
Loading
Loading