Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory usage #100

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Reduce memory usage #100

merged 1 commit into from
Jan 5, 2025

Conversation

oraluben
Copy link
Contributor

@oraluben oraluben commented Jan 3, 2025 •
edited
Loading

by run attn impls one by one and clear CUDA memory after each case.

This allows to run benchmark on nvidia A10.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 3, 2025
@oraluben oraluben marked this pull request as ready for review January 3, 2025 05:00
@oraluben oraluben marked this pull request as draft January 3, 2025 05:06
@oraluben oraluben marked this pull request as ready for review January 3, 2025 06:09
drisspg
drisspg approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@drisspg drisspg merged commit a710e18 into pytorch-labs:main Jan 5, 2025
2 checks passed
@oraluben oraluben deleted the reduce-mem branch January 6, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oraluben @drisspg @facebook-github-bot