Declare support for 3.13 #1282
Merged
Declare support for 3.13 #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian
reviewed
Jul 8, 2024
noxfile.py
Outdated
| @@ -35,7 +35,7 @@ | |||
| "The Unlicense (Unlicense)", | |||
| ] | |||
|
|
|||
| SUPPORTED = ["3.8", "3.9", "3.10", "pypy3.10", "3.11", "3.12"] | |||
| SUPPORTED = ["3.8", "3.9", "3.10", "pypy3.10", "3.11", "3.12", "3.13"] | |||
| LATEST = SUPPORTED[-1] | |||
There was a problem hiding this comment.
3.13 is still not released, so we should "leave this" pointing to "3.12" (by hardcoding it instead of doing [-1] I guess).
That also presumably explains the CI failure(s), some things don't support 3.13 wheels yet.
Otherwise this looks good!
There was a problem hiding this comment.
Thank you! The line is now fixed as suggested. I noticed rpds-py had no wheels because of this line: https://github.com/crate-py/rpds/blob/0b6ea677974fdf2856d975e9386e16bec441424f/.github/workflows/CI.yml#L164. I will open the PR for building the wheels in https://github.com/crate-py/rpds/.
There was a problem hiding this comment.
Here is the PR for building wheels for Python 3.13: crate-py/rpds#80.
Fixes: python-jsonschema#1264. Hardcode the `LATEST_STABLE` variable in `noxfile.py` to equal the latest stable Python release.
|
Perfect, thanks again! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1264.
📚 Documentation preview 📚: https://python-jsonschema--1282.org.readthedocs.build/en/1282/