Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using sys.exc_info #247

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

bluetech
Copy link
Member

In Python 3 it's better to handle exception objects directly, they now carry their traceback.

@bluetech
Copy link
Member Author

Some py3.8 issue, marking as draft for now.

@bluetech bluetech marked this pull request as draft February 24, 2024 10:09
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely thanks

In Python 3 it's better to handle exception objects directly, they now
carry their traceback.
@bluetech bluetech marked this pull request as ready for review February 24, 2024 10:46
@bluetech bluetech merged commit 1900890 into pytest-dev:master Feb 24, 2024
13 checks passed
@bluetech bluetech deleted the no-sys-exc-info branch February 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants