Full models audit

[jmcouffin]

Preflight audit of all models, including linked models.

⚠️ Links must be loaded

This QC tools returns the following data:

• project name, number, client, phases, worksets
• element count
• purgeable elements count
• all warnings count
• critical warnings count
• rvtlinks count
• activated analytical model elements count
• rooms count
• unplaced rooms count
• sheets count
• views count
• views not on sheets
• schedules not sheeted count
• copied views count
• view templates count
• unused view templates count
• filters count
• unused view filters count
• materials count
• line patterns count
• dwgs count
• linked dwg count
• inplace family count
• not parametric families count
• family count
• imports subcats count
• generic models types count
• detail components count
• text notes types count
• text notes types with width factor != 1
• text notes count
• text notes with allCaps applied
• detail groups count
• detail groups types count
• model group count
• model group type count
• reference planes count
• unnamed reference planes count
• detail lines count
• dimension types count
• dimension count
• dimension overrides count
• revision clouds count

[sanzoghenzo]

Quick first review, I didn't check the query module yet.
Just thinking out loud: I get that you wanted to separate the data collection from the output, but since the logic is already in the query module, wouldn't it be better to group the the data variables to the related frame and then split each group to its own function?

[jmcouffin]

I still need to review the numbers outputed and maybe get to solve why the document is not properly stored / cached

[sanzoghenzo]

It's time to roast the config module 😅

[sanzoghenzo]

Another quick go at the main script.

Since this is a new file, I would start to enforce a bit of formatting rules.
black has good defaults and it is already installed in the pipenv, so you just need to

pipenv run black extensions/pyRevitTools.extension/checks/audit_all_check.py

[sanzoghenzo]

Just a few comments on the query, but this is because it's late...

In general, I have a few points to make:

• why return a list of item and it's count instead of using len(items) where it is needed?
• the ToElement() should never be None, at most it is an empty list, so all the is None checks are useless. Or am I missing something?
• use pyrevit.revit.db.query module more 😉 like get_elements_by_class... and if there are missing functionality, add it there

[jmcouffin]

Hi @sanzoghenzo
That puppy is ready for your review. I put a lot of love into this one. Hoping this won't be too painful to look at 😄

[sanzoghenzo]

I may have gone too hard on some things, feel free to pick whatever advice you want 😉

[jmcouffin]

I may have gone too hard on some things, feel free to pick whatever advice you want 😉

Never mad. This is all constructive criticism.
Will look at it later
Thanks

[jmcouffin]

I went through the whole thing! Damned... a beast of a refactoring. I learned a lot. Thanks @sanzoghenzo

I am ready to merge except for that one SOB groups counting... for the life of me, I spend way too much time on this.
in a very simple homemade sample, the count is right, in the revit arch sample it is off...

[sanzoghenzo]

Last one: since there are no None checks in place, avoid having the function arguments default to it

[sanzoghenzo]

Looks good to me!

[jmcouffin]

The puppy is out in the wild.
Thank you so much @sanzoghenzo for the comments!

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.25031+1700-wip