-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split inflow in ppl units + same hydro profile in alt. clustering #1119
base: main
Are you sure you want to change the base?
Split inflow in ppl units + same hydro profile in alt. clustering #1119
Conversation
Sorry @davide-f I had some issues locally and had to re-open the PR. I'm reporting your comments here: Great contribution @danielelerede-oet ! Few comments:
My perspective is the following:
|
Hi @davide-f , I performed the additional checks you requested on both USA and Nigeria (which is not actually affected by the changes in |
Great :D |
Sure! Of course I also forgot to mention that Nigeria is not affected by the changes in |
@danielelerede-oet weren't you using the default configurations for the tests? |
Yes, I was, but I also performed an additional check on the US model! |
Closes #759 .
Changes proposed in this Pull Request
build_renewable_profiles
: the computation of hydro_profile.nc is not distinguished whether alternative clustering is applied or not.add_electricity
: the indexing of the different power plants is performed according to the bus either in case alternative clustering is applied or not and a hydro_inflow_factor is computed prior to the computation of inflow_t to split the inflow according to the capacity of each different unit of each power plant (beforehand, the same inflow value was assigned to all the units of a single power plant possibly causing an overestimation of the total generation).Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.