Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when reading mosaic data in files from previous pypeit versions. #1865

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

kbwestfall
Copy link
Collaborator

As titled. Addresses #1856 .

I added a Mosaic test and changed the code a bit, but the main fix is just from the one-line change in specobjs.py.

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kbwestfall!

@kbwestfall
Copy link
Collaborator Author

Nearly everything passes:

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  257 passed, 6565 warnings in 382.18s (0:06:22) ---
--- PYTEST UNIT TESTS PASSED  152 passed, 2670 warnings in 971.22s (0:16:11) ---
--- PYTEST VET TESTS PASSED  62 passed, 106524 warnings in 5465.39s (1:31:05) ---
--- PYPEIT DEVELOPMENT SUITE FAILED 1/247 TESTS  ---
Failed tests:
    keck_hires/J0100+2802_H204Hr_RED_C1_ECH_0.75_XD_1.69_1x2 pypeit
Skipped tests:
Testing Started at 2024-10-29T22:50:10.498613
Testing Completed at 2024-10-30T12:54:21.111793
Total Time: 14:04:10.613180

I'll look into the one failure now.

@kbwestfall
Copy link
Collaborator Author

I can't reproduce the keck_hires/J0100+2802_H204Hr_RED_C1_ECH_0.75_XD_1.69_1x2 pypeit error on my machine. So I think this one is ready to merge.

@tbowers7 tbowers7 linked an issue Oct 30, 2024 that may be closed by this pull request
@kbwestfall kbwestfall merged commit e35362a into develop Oct 31, 2024
18 checks passed
@kbwestfall kbwestfall deleted the mosaic_try_old branch October 31, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propagate --try_old flag functionality to the Mosaic object
3 participants