Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX to slitless pixflat #1863

Merged
merged 3 commits into from
Oct 29, 2024
Merged

HOTFIX to slitless pixflat #1863

merged 3 commits into from
Oct 29, 2024

Conversation

debora-pe
Copy link
Collaborator

Set slit_illum_finecorr = False when computing the slitless pixelflat

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.07%. Comparing base (2b53647) to head (8fe916a).

Files with missing lines Patch % Lines
pypeit/flatfield.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1863      +/-   ##
===========================================
- Coverage    38.07%   38.07%   -0.01%     
===========================================
  Files          211      211              
  Lines        49051    49052       +1     
===========================================
  Hits         18675    18675              
- Misses       30376    30377       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rcooke-ast rcooke-ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@debora-pe debora-pe merged commit 23630d7 into develop Oct 29, 2024
18 checks passed
@debora-pe debora-pe deleted the hotfix_slitless branch October 29, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants