Adding orderStacks as a default coadd.py output for Echelle spectrographs #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbwestfall
requested changes
Aug 26, 2024
debora-pe
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Hey @Adolfo1519 , the changes here look OK.
I am just confused about the description of the PR. It says "Adding orderStacks as a default coadd.py output for Echelle spectrographs", but I cannot tell which part of the code here is doing that. Was it done in a previous PR and this is an update to that?
Also, if the orderstack is now provided by default for echelle, what happened to the -m flag? Was it removed?
Sorry if I missed something in previous PRs.
debora-pe
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderStacks has been created to contain the order stacks output by coadd.py. Originally these were output as part of the onespec object when the -m flag was set, following the NIRSPEC merge. However, this has now been made into a default output for echelle spectrographs and the stacks are output in the original wavelength solution of each order (if it is monotonic).