Use Emscripten's llvm-readobj
by default
#73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a rework of pyodide/pyodide#4186. I think the premise of the original PR—which I agree with—was that it is better for us to rely on
llvm-readobj
from the Emscripten toolchain first, before seeking the one onPATH
.Additional info
llvm-readobj
is not available with Homebrew's Emscripten recipe, but with LLVM (of course):$(brew --prefix llvm)/bin/llvm-readobj --version
v.s. Emscripten 3.1.58 (note the slightly older LLVM, but tip-of-tree at that time for Emscripten 3.1.58 which we use at the time of writing):
Unfortunately, I can't test what the conda-forge feedstock for Emscripten does as of now, because I can't install it on my M-series machine. I've opened an issue about it here: conda-forge/emscripten-feedstock#35