Validate Python version when initializing xbuildenv #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
approved these changes
Nov 24, 2024
pyodide_build/xbuildenv.py
Outdated
| raise ValueError( | ||
| f"local Python version ({version_local}) does not match the Python version ({version_on_install}) " | ||
| "used to create the Pyodide cross-build environment. " | ||
| "Please reinstall the xbuildenv, by running `pyodide xbuildenv uninstall` and then `pyodide xbuildenv install`" |
There was a problem hiding this comment.
Or maybe switch back to the original Python version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check when initializing xbuildenv (==
init_environment) to make sure the local Python version used to install the xbuildenv was not changed.This prevents the following scenario:
Related issue: #44